Remove mozjpeg #285
Open
Remove mozjpeg #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MelSumner
commented
Oct 28, 2024
| && ./configure \ | ||
| && make \ | ||
| && make install | ||
|
|
||
| # we must not use any packages which depend directly or indirectly on libjpeg, | ||
| # since we want to use our own mozjpeg build | ||
| RUN apt-get install -y \ |
There was a problem hiding this comment.
@benschwarz does this mean we don't need these either, since we're removing mozjpeg?
|
@MelSumner Pretty much the whole docker file is removable seeing as we don't want mozjpeg (or all the deps required for the build). Additionally, we should be able to use |
|
Are you happy with where this is for now, or is there still more to do? |
benschwarz
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A draft PR to see how I can progress with removing mozjpeg
This PR:
The docker command referenced in the CONTRIBUTING file is successfully running locally.
Tests also pass locally:
